Skip to content

Fix minor grammatical errors #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

kristenmazza wants to merge 2 commits into javascript-tutorial:master

from kristenmazza:fix-grammar-errors

Open

Fix minor grammatical errors #3410

kristenmazza wants to merge 2 commits into javascript-tutorial:master from kristenmazza:fix-grammar-errors

Conversation

Copy link

@kristenmazza kristenmazza commented Mar 19, 2023 •

edited

Loading

Fixes grammatical errors including word choice and punctuation


 Fix minor grammatical errors

f51759d

Copy link

CLAassistant commented Mar 19, 2023 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

shallow-beach suggested changes

View reviewed changes

1-js/07-object-properties/02-property-accessors/article.md Outdated

The first kind is *data properties*. We already know how to work with them. All properties that we've been using until now were data properties.

The second type of property is something new. It's an *accessor property*. They are essentially functions that execute on getting and setting a value, but look like regular properties to an external code.

The second type of property is something new. It's an *accessor property*. They are essentially functions that execute on getting and setting a value but look like regular properties to an external code.

Copy link

Contributor

@shallow-beach shallow-beach Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disagree, clearer with comma

1-js/07-object-properties/02-property-accessors/article.md Outdated

```

Now the old code works too and we've got a nice additional property.

Now the old code works, too, and we've got a nice additional property.

Copy link

Contributor

@shallow-beach shallow-beach Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe:

Now the old code works too, and we've got a nice additional property.

1-js/07-object-properties/02-property-accessors/article.md

- **`set`** -- a function with one argument that is called when the property is set,

- **`enumerable`** -- same as for data properties,

- **`configurable`** -- same as for data properties.

Copy link

Contributor

@shallow-beach shallow-beach Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might suggest dropping punctuation at end of bullets as well:

get -- a function without arguments that works when a property is read

set -- a function with one argument that is called when the property is set

enumerable -- same as for data properties

configurable -- same as for data properties

@javascript-translate-bot

Copy link

javascript-translate-bot commented Aug 24, 2024

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested label


 Update punctuation

2cf1837

Copy link

Author

kristenmazza commented Aug 24, 2024

/done

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels

@javascript-translate-bot javascript-translate-bot requested a review from a team

August 24, 2024 15:37

@kristenmazza kristenmazza requested a review from shallow-beach

August 24, 2024 19:50

shallow-beach approved these changes

View reviewed changes

@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants

@kristenmazza @CLAassistant @javascript-translate-bot @shallow-beach